Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: app entitlements #12090

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

core: app entitlements #12090

wants to merge 12 commits into from

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 20, 2024 •
edited
Loading

Details

Application scoped entitlements which can be used to configure authorization within a given application. Entitlements can be assigned to individual users or groups and can store attributes

  • Add scope mapping for entitlements
  • Add docs
  • Add note that policies are not supported for bindings to the entitlements yet
  • Add validation that policies cant be set in bindings to this target type

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners November 20, 2024 14:12
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 8a66350
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/674628072838c9000833bfbc

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 8a66350
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6746280744923d00085f0bda

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.07407% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (630e0e6) to head (8a66350).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/models.py 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12090      +/-   ##
==========================================
- Coverage   92.69%   92.69%   -0.01%     
==========================================
  Files         761      763       +2     
  Lines       38025    38154     +129     
==========================================
+ Hits        35249    35368     +119     
- Misses       2776     2786      +10
Flag Coverage Δ
e2e 49.17% <30.55%> (-0.06%) ⬇️
integration 24.79% <10.18%> (-0.05%) ⬇️
unit 90.23% <99.07%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu
core: initial app entitlements
e7a0fc7 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
base off of pbm
3347e6c 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
add tests and oauth2
50711d1 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
add to proxy
da3ac78 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
rewrite to use bindings
480b7d4 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
make policy bindings form and list more customizable
24eb2ae 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
fix tests
25602f4 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
double fix
506c704 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
fix ci push logic
fb05434 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu BeryJu requested a review from a team as a code owner November 25, 2024 17:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-8a66350f9a691677eb0e10f3fe86e3f5c0e33b0a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-8a66350f9a691677eb0e10f3fe86e3f5c0e33b0a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-8a66350f9a691677eb0e10f3fe86e3f5c0e33b0a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-8a66350f9a691677eb0e10f3fe86e3f5c0e33b0a-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu
refine permissions
32684fe 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
add missing rbac modal to app entitlements
63aa48e 
Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
skip flaky test
8a66350 
Signed-off-by: Jens Langhammer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BeryJu